feat: add multi speed fast forward (1x-16x) to game menu#1115
feat: add multi speed fast forward (1x-16x) to game menu#1115mdevolde wants to merge 1 commit intoSwordfish90:masterfrom
Conversation
|
Thanks @mdevolde looks like a nice PR 😊 Two questions:
|
|
Based on my reading of the description, this does not add a button/key binding. I also really want that feature. #1077 seems to add this feature though! But so far the PR has been ignored. If you end up building lemuroid with that PR could you share the APK? Or maybe I will try building it myself at some point... |
|
@mgiessing @kovasap I didn't add a shortcut for "fast-forward" because it is yet implemented, but I didn't notice that, because this shortcut has no default value, it is impossible to configure it. I will look at this soon. |
- add multi speed fast forward - allow to set default unset shortcuts (including f-f) - allow to edit the f-f cycle with shortcut
93b3875 to
7e8072a
Compare
|
So, I allowed users to set a value for shortcuts that has no default value, and I allowed users to edit the "fast-forward cycle" (you can configure your emulator to cycle between 1x, x8 by pressing the fast forward shortcut instead of cycling between 1x, x2, x4, x8, x16). I retested the entire workflow on phone, with and without controller. |
feat: add multi speed fast forward (1x-16x) to game menu
Motivations
The purpose of this PR is to allow players to have more options when adjusting the game speed (which is currently limited to x1 or x2).
Changes
Interface changes
ListPreferencewith the same speeds as above.On both platforms, displays the note “Some speeds may be limited depending on the core.”
Code changes
EXTRA_FRAME_SPEEDextra and aRESULT_SET_FRAME_SPEEDresult.BaseGameActivityapplies it toretroGameView.frameSpeed.EXTRA_FAST_FORWARD/RESULT_ENABLE_FAST_FORWARD.Testing
Related issues
Closes #650
Closes #837